[TYPO3-core] RFC: protect localconf.php from being lost

Martin Kutschker Martin.Kutschker at blackbox.net
Sat Dec 17 10:50:21 CET 2005


Michael Stucki <michael at typo3.org> writes on 
Fri, 16 Dec 2005 17:27:45 +0100 (MET):

> 
> >> As for the die() calls - what about just putting the error message
> >> into $this->messages[] and hope the admin will look carefully
> > > enough
> >> at the output? This way it could be called "graceful" error
> > > handling,
> >> somewhat at least.
> > 
> > I don't know where the message strings are used. When I changed the
> > settings of an extension in the extension manager I did not see,
> > the "updated" message. So the display of the message has to be
> > implemented at
> > least there. But again, I don't want to don this right now. I'm
> > only fixing the dataloss bug (#1878).
> 
> I already changed this somewhere in my patch-pipeline. Will be changed
> by me soon (just change debug => t3lib_div::debug).


There are no debug() calls in this function.


> So then it should be no problem to move these messages to
> $this->messages[].
> Can you do that, please?


Yes, but what shall the function return in such a case? "nochanges" or "error"? "nochanges" is th return value if $this->allowUpdateLocalConf is false. I don't care, but your changes should be able to handle the return value.

Masi

Masi 



More information about the TYPO3-team-core mailing list