[TYPO3-core] 0001822: There is no API to list tables in theWeb- >Page module

[Michael Stucki]

Hello Franz,

ok, seems we're making progress.

> [franz at localhost ~]$ diff -ru
> /var/www/html/typo3cvs/TYPO3core/typo3/sysext/cms/layout/db_layout.php
> /var/www/html/typo3/sysext/cms/layout/db_layout.php > diff.txt
> [franz at localhost ~]$ diff -ru
> /var/www/html/typo3cvs/TYPO3core/typo3/sysext/cms/layout/class.tx_cms_layou
>t.php /var/www/html/typo3/sysext/cms/layout/class.tx_cms_layout.php >>
> diff.txt [franz at localhost ~]$ vi diff.txt
> [franz at localhost ~]$ mv diff.txt cms_layout.diff

Don't make the patches per-file, instead, do it in one run (this is why the 
"-r" parameter is submitted) and remove the stuff that is not relevant 
afterwards. Much easier!

Still didn't test the patch, but here are some more comments after a rough 
review:

- Coding style: Afer "if (...)" and "elseif (...)" but NOT after "else" we
  write a tab before the opening bracket.
- Remove the comment "local variables" on line 252
- Remove the empty lines 363, 1124 and 1131
- At the end of the function getTable_external, you are calling
  $this->makeOrdinaryList but with $addWhere as 4th parameter, while it should
  be the fifth. In fact, you forgot to add $icon here. Please change.

Regards, michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20051205/c6217e45/attachment.pgp