[TYPO3-team-core-v5] Comments about commits during my holidays ...

[Andreas Förthner]

Hi,

>--------------------------------------------------------------------------
>--------
>May 19 2011 [+FEATURE] Add a typo3.org SSO authentication provider
>Change-Id: Iffba555c5b4e949c4b61b5f4c5360e2bf6a95b4a
>
>The SSO authentication provider is great, but does it really belong to
>the FLOW3 package? It's very specific to TYPO3 / typo3.org and I plead
>for moving it into a dedicated / other package.

Could someone create a new package / git repository for this? The I can
move the provider in there.

>--------------------------------------------------------------------------
>--------
>April 26 2011 [TASK] Use native serialize for session scope objects
>Change-Id: I6b7e17806196f82c5744050cf5d15b7f081416c4
>
>In this changeset from end of april Andi introduced two new methods to
>the DI ProxyClassBuilder:
>
>https://review.typo3.org/#patch,sidebyside,1485,12,Classes/Object/Dependen
>cyInjection/ProxyClassBuilder.php
>
>While I agree that this functionality is needed, I think that the DI
>ProxyClassBuilder is simply the wrong place to add it. It doesn't have
>anything to do with Dependency Injection (as far as I understand) and
>especially the code introduced in buildSerializeRelatedEntitiesCode() is
>almost too long to be introduced in an inline string. Can't this be
>introduced by some advice?

Well, somehow this code is responsible to re-inject all dependencies and
entities after
serialization. Of course we could put it somewhere else. An advice for the
proxy class builder?! Or an advice for every
object? I don't think it's that easy to find a pointcut expression that
would match the needed classes, or do you
have a suggestion here? I'm all in to change things here, but simply
didn't have a better idea for now. If you have
any ideas, just tell me and I'll work on it ;-)

Greets Andi


Andreas Förthner
Leiter Web-Entwicklung

Telefon: +49 (911) 539909 - 0
E-Mail: andreas.foerthner at netlogix.de
Website: media.netlogix.de


--
netlogix GmbH & Co. KG
IT-Services | IT-Training | Media
Andernacher Straße 53 | 90411 Nürnberg
Telefon: +49 (911) 539909 - 0 | Fax: +49 (911) 539909 - 99
E-Mail: info at netlogix.de | Internet: http://www.netlogix.de

netlogix GmbH & Co. KG ist eingetragen am Amtsgericht Nürnberg (HRA 13338)
Persönlich haftende Gesellschafterin: netlogix Verwaltungs GmbH (HRB 20634)
Umsatzsteuer-Identifikationsnummer: DE 233472254
Geschäftsführer: Stefan Buchta, Matthias Schmidt