[TYPO3-team-core-v5] Comments about commits during my holidays ...

[Lienhart Woitok]

Hi Karsten, Bastian,

>> "[...] command line argument parsing is broken, for example -x '<div class="foo">' results in "foo">. Arguments of the form --blah=hurz don't work at all, but --blah hurz (without =) does."
>>
>> Apart from that, currently the whole CLI subpackage has no unit tests at all. I think, we should change that ;)
>
> The CLI argument parsing actually has a test, and according to that test at least the second case should work. Can you double check that? Thanks!

I tested this with Extbase version, so not sure how it behaves in FLOW3. After thinking about the code again (I didn't run anything right now, as my test extension is on my notebook which sleeps at home ;-)) I think the issue is not having the = sign in the argument ----blah=hurz, but having no argument or option following it. In Tx_Extbase_MVC_CLI_RequestBuilder::parseRawCommandLineArguments(), the argument being processed is shifted from the array of command line arguments. Tx_Extbase_MVC_CLI_RequestBuilder::getValueOfCurrentCommandLineOption() on the other hand returns TRUE if the array of command line arguments is empty (which would be fine for a boolean option but not for a string or numeric value).

I hope this helps clarifying the issue.

Kind regards




Lienhart Woitok
Web-Entwickler

Telefon: +49 (911) 539909 - 0
E-Mail: Lienhart.Woitok at netlogix.de
Website: media.netlogix.de


--
netlogix GmbH & Co. KG
IT-Services | IT-Training | Media
Andernacher Straße 53 | 90411 Nürnberg
Telefon: +49 (911) 539909 - 0 | Fax: +49 (911) 539909 - 99
E-Mail: info at netlogix.de | Internet: http://www.netlogix.de

netlogix GmbH & Co. KG ist eingetragen am Amtsgericht Nürnberg (HRA 13338)
Persönlich haftende Gesellschafterin: netlogix Verwaltungs GmbH (HRB 20634)
Umsatzsteuer-Identifikationsnummer: DE 233472254
Geschäftsführer: Stefan Buchta, Matthias Schmidt