[TYPO3-team-core-v5] Comments about commits during my holidays ...

[Karsten Dambekalns]

Hi.

On 02.06.2011, at 04:47, Robert Lemke wrote:
> May 24 2011 TASK] Run Doctrine schema and proxy setup only if needed
> Change-Id: I846fc4c7eff4523947bb17f3963e518390547199
> 
> I don't think that the CacheManager is the right place for
> markDoctrineProxyCodeOutdatedByChangedFiles(). This slot should rather
> be in a class of the Persistence subpackage or if there's no nice place,
> put it into the bootstrap for the time being (there are other slot lying
> around already).

Well, it's right below another "mark as outdated" method, it simply was the easiest solution and seemed ok :)

If I go about to change that, shouldn't the other method be moved as well?

> May 08 2011 [FEATURE][BUGFIX] Calculate referenced column names from
> class code
> Change-Id: If2a4612a326b6fbdfa4a27363c491723ae5cf1e7
> 
> Karsten, you're using "_Original" in some regexes there. There currently
> is a static property in \F3\FLOW3\Object\Proxy\Compiler which defines
> that string. We either remove that (and thus say we won't change it
> anytime soon again) or use should refer to that variable.

Ah, very helpful. I'll change that. Why is it not a constant?

Regards,
Karsten
-- 
Karsten Dambekalns
Gimme Five!
http://typo3.org/gimmefive