[TYPO3-team-core-v5] Comments about commits during my holidays ...

Bastian Waidelich bastian at typo3.org
Sun Jun 5 23:53:40 CEST 2011


Robert Lemke wrote:

Hi Robert,

> I spent this morning with going through all changesets you merged during
> my holidays [...]  rants ;-)

I agree to your points and I'll take care of pushing follow ups for my 
affected changes.

Two further remarks concerning the CLI Commands:
As I said in the Scrum meeting from Wednesday I have backported the 
Command Controller implementation to Extbase [1].
Lienhart Woitok wrote following comment:

"[...] command line argument parsing is broken, for example -x '<div 
class="foo">' results in "foo">. Arguments of the form --blah=hurz don't 
work at all, but --blah hurz (without =) does."

Apart from that, currently the whole CLI subpackage has no unit tests at 
all. I think, we should change that ;)

See you tomorrow,
Bastian



[1] https://review.typo3.org/#change,2119 (change set #4)


More information about the TYPO3-team-core-v5 mailing list