[TYPO3-team-core-v5] File name conventions and licenses
Robert Lemke
robert at typo3.org
Tue May 18 22:47:17 CEST 2010
Hi folks,
I just worked a bit on the page not found handling and stumbled over two things, file naming and third-party licenses.
First thing is that the image file names are not consistent, examples are: "bg_transparent-red.png" "warning-sign.png". We don't have file name conventions explicitly for media files yet, but in general I feel like they don't match what we currently have in other parts of FLOW3 and TYPO3.
My suggestion are these simple rules:
- all file names are upper camel case
- if a separator is really necessary, use the dash "-"
- don't use abbrvs
- try to follow naming patterns you find elsewhere
The second thing are licenses. You must not commit any code you didn't create yourself without checking with Karsten on me on beforehand. Sorry to be so strict, but it is important that we keep the whole code base IP clean.
If found a copyright notice by Yahoo in one of the CSS files. That's only three lines, but we need to check how / if we can use them. Maybe there's a simple way / alternative solution with which we can avoid including it.
And in general please make sure that if you commit code created by others that these contributors have also signed the CLA. This is certainly not necessary for bug fixes but it is important for any other copyrightable code.
Thanks for taking care!
robert
More information about the TYPO3-team-core-v5
mailing list