[TYPO3-team-core-v5] Changelog considerations
Karsten Dambekalns
karsten at typo3.org
Tue Jul 7 12:51:37 CEST 2009
Hi Bastian.
On 06.07.2009 16:35 Uhr, Bastian Waidelich wrote:
> Some questions though:
Just to make sure, you saw the new section in the coding guidelines?
> The difference between [~API] and [~TASK] is, that in the second case
> I'm changing something that is not code related or is not part of the
> public API (marked @internal). Correct?
Well, ~API is for public API changes. You might have ~BUGFIX touching
the internal API, but no ~TASK with the commit. Clear? ;)
> What if I'm committing a feature that adds a method to the API?
> "[+API][+FEATURE] FLOW3 (Core): Method initializeDrupal() has been added
> to the Bootsrap"
> Or would I still have to write two lines?
No, one line. Is what I wrote ("prefixed with one or more of the
following codes") misleading or not clear enough? Anyway, I added this
very example to the documentation...
> When changing something that is not related to a sub package (e.g.
> global configuration) I'd leave out the "(SubPackage)"-part, right?
Yes.
>>> And we might even enforce them by a simple pre-commit hook.
>>> What do you think?
[...]
> Maybe we should allow an additional type [NOTE] to be able to circumvent
> the check then.
Well, why rules when there are exceptions? I guess in any case TASK
would be as good as NOTE.
Regards,
Karsten
More information about the TYPO3-team-core-v5
mailing list