[TYPO3-team-core-v5] [!!!] Coding style and merging changes

[Tim Eilers]

Hi fellow Karsten,

this reminds me of taking up work on CGL validator (aka FLOW3CGL) again.

Sorry for being quiet a longer time, i was busy with other things (f.e.
moving) and this got out of focus unfortunately. Plus i sometimes don't
understand many things, so i really need Malte for a lot of things :(

I'll contact Malte the next days to do more active work on FLOW3CGL
again and get it fully working and to finally add the missing checks.

After that i recommend every coder to use it to check their code. Much
of Karstens points are already checked.


Happy new year to everyone :)
Tim.


Karsten Dambekalns schrieb:
> Hi fellow coders.
> 
> While I appreciate hard work, and am happy if people code around the 
> clock, it may be helpful to commit during times when you are more awake. :)
> 
> 
> I just committed a few changes to a recent commit, and want you to point 
> to the CGL and the importance of seemingly irrelevant things.
> 
> * Indentation with tabs, not spaces
> * no extra spaces in @param and similar annotations
> * @param annotations need the variable name; but no : after that
> * We need file- and class-level docblocks
> * Annotations need to be present and correct
> 
> When merging changes from SVN into your working copy, look if you need 
> to adjust your pending code beyond simply resolving conflicts! After my 
> license change commit some files have been committed that still had the 
> old GPL file header and @license annotation.
> 
> 
> Regards,
> Karsten
> _______________________________________________
> TYPO3-team-core-v5 mailing list
> TYPO3-team-core-v5 at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core-v5
>