[TYPO3-team-core-v5] RSA Implementation / Login Controller

[Robert Lemke]

Hi Andi,

I just reviewed most of the code you committed related to the RSA  
implementation. In general: great to see that you also use mock  
objects and the vfs in your tests!

I fixed a few style glitches but there's one thing which doesn't  
really work yet: the login controller. On my machine the RSA Username  
Password token is not available (maybe because the keypairs aren't  
even generated?) and therefore the controller crashes because you made  
it only work with the RSA variant.

It also seems like the key storage is not yet completely functional.  
Is it on purpose that you store the keys in the _temporary_ directory?  
I've also seen that you commented the error checking out which should  
warn if the keystorage directory couldn't be created.

Just my 2 notes ;-)

Cheers,
robert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: Signierter Teil der Nachricht
Url : http://lists.netfielders.de/pipermail/typo3-team-core-v5/attachments/20090209/2c609b0a/attachment.pgp