[TYPO3-team-core-v5] FLOW3: First code sprint of F3PR

Tim Eilers tim.eilers at web.de
Tue Sep 16 11:06:59 CEST 2008


Hello,

sorry if this goes to a wrong thread, but my webmailer is to silly to handle newsgroups correct.

> Hi.
> 
> On 16.09.2008, at 10:28, Malte Jansen wrote:
> > So we should allowed the inline-comment and should only check the 
> > intending of the comment.
> 
> (Indenting, although checking the intention would be even better ;) )

Hrhr, that one was good :D
Ok, today i will look for a KI or a C2B (computer to brain) connector to get the intention... 


> I'd rather not allow it. Or make sure you check that it is never used in 
> frotn of classes, methods and class members (constants/variables), 
> because it may happen that you have functionally relevant annotations 
> (like @entity, @var, @scope) in a block that is not a docblock this way. 
> Saw this more than once already, and usually you look elsewhere for some 
> error first.
> 
> If instead comments would have to start with either /** or // the thing 
> would be clear(er).
> 
> So, my vote goes for // even for multiline comments.

+1 for that all from me.

/* foobar */ can still be used to quickly deactivate code local, but should never be in committed code.
Exception: The copyright comment at beginning of the file.

I also would like to extend it to not allow any content (exept one linebreak and the indenting tabs) between the doccomment and the class / function / variable
It makes the whole thing cleaner.

If i get a +1 i'll make a feature issue out if it...


Cheers, Tim.


More information about the TYPO3-team-core-v5 mailing list