[TYPO3-team-core-v5] Sniff checking for PHP open tags - problem to solve

[Karsten Dambekalns]

Hi.

On 06.06.2008, at 20:33, Tim Eilers wrote:
> Second: Malte is currently refactoring the whole FLOW3CGL package, so
> the code in the svn is a little bit outdated until he will commit. I  
> am

Right, but he changed something that really broke CGL checking and a  
whole bunch of unit tests. Overall the FLOW3CGL package is violating  
it's own unit tests and CGL checks a lot.

> Phew, i never heard of that php.ini option until today...

Oops, it's one of the most-used ones, at least IMHO. :)

> i have to
> check what token php recognizes instead of T_OPEN_TAG, and what it

Well, T_OPEN_TAG stays T_OPEN_TAG, but is only detected for "<?php",  
no longer for "<?" and "<=".

> I agree to you suggestion to change the fixtures (which you already
> made, like i see in the svn repo). I believe that not much developers
> have set that option in php.ini, so the risk of broken code is very  
> low.


Well, having short_open_tag set to off is recommended for a whole  
bunch of reasons. See php.ini-recommended in any PHP distribution and/ 
or source.

Regards,
Karsten
-- 
Karsten Dambekalns
Gimme Five!
http://typo3.org/gimmefive


-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 304 bytes
Desc: This is a digitally signed message part
Url : http://lists.netfielders.de/pipermail/typo3-team-core-v5/attachments/20080607/14f76614/attachment.pgp