[TYPO3-commerce] RFC Feature #4980: Extended payment functionality

[Michael Knabe]

Hi,
I finally found some time to review this thing. Looks good and works well.
Old payment providers (I tested paypal2commerce) will however fail as
you added a parameter ($this) to the instantiation. I added a
try-/catch-block around the makeInstance-call which logs a deprecation
message and instantiates the payment without a parameter.

With this change added you'll get my +1 on reading and testing.

BTW: If you are also trying to test paypal2commerce you'll have to
replace some occurrences of $basket->basket_sum_gross with
$basket->getGrossSum() as the property is protected. However, this has
nothing to do with this patch but with some cleanup you made earlier. I
will file a patch to the paypal2commerce issue tracker that fixes this
on their side.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commerce-payment-18.diff
Type: text/x-patch
Size: 85065 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-commerce/attachments/20110811/9dde98a2/attachment-0001.bin>