[TYPO3-commerce] RFC: #10433: Ressource leak in tx_commerce_product::get_Articles_by_AttributeArray

[Ingo Schmitt]

Hi Michael,

> Hi Ingo,
> 
>> $result is not set, if there is an SQL Error. SQL Errors can be caused by the code, but can also be caused by the database and other reasons, which are not in control by commerce. So I want to have a check if $result is set.
> $result is set to FALSE then which is not a problem as sql_fetch_assoc handles it nicely by writing a devlog entry which is IMHO cleaner than ignoring the error silently as the current code does.

So please update you patch, that it's written to devlog instead removing the if-clause.

Ingo

> Actually, if your database is not reachable you have bigger problems than commerce failing here.
> BTW, if this query returns nothing due to a defective sql syntax or database, you get a fatal error in tx_commerce_pibase anyway.
> 
> Cheers, Michael
> _______________________________________________
> TYPO3-team-commerce mailing list
> TYPO3-team-commerce at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-commerce
> 
> 


Mit freundlichen Gruessen
Ingo Schmitt

-- 
Marketing Factory Consulting GmbH  *   mailto:is at marketing-factory.de
Stephanienstrasse 36               *          Tel.: +49 211-361176-63
D-40211 Duesseldorf, Germany       *          Fax:  +49 211-361176-99
Amtsgericht Duesseldorf HRB 53971  * http://www.marketing-factory.de/

Geschaeftsfuehrer:    Peter Faisst   |   Katja Faisst
Karoline Steinfatt   |   Christoph Allefeld   |   Markus M. Kimmel