[TYPO3-commerce] RFC: #10433: Ressource leak in tx_commerce_product::get_Articles_by_AttributeArray

[Ingo Schmitt]

Hi Michael,

$result is not set, if there is an SQL Error. SQL Errors can be caused by the code, but can also be caused by the database and other reasons, which are not in control by commerce. So I want to have a check if $result is set.

ingo

> $result is always set (as long as there is no SQL error which would be another bug then). If the result set is empty, the while loop will simply end before the first run.
> Even if there is an error in the SQL-query it would not lead to an error, as the t3lib_db-methods do already check for a wrong input and handle it the correct way (i.e. write a message to devlog)
> 
> Cheers, Michael
> _______________________________________________
> TYPO3-team-commerce mailing list
> TYPO3-team-commerce at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-commerce
> 
> 


Mit freundlichen Gruessen
Ingo Schmitt

-- 
Marketing Factory Consulting GmbH  *   mailto:is at marketing-factory.de
Stephanienstrasse 36               *          Tel.: +49 211-361176-63
D-40211 Duesseldorf, Germany       *          Fax:  +49 211-361176-99
Amtsgericht Duesseldorf HRB 53971  * http://www.marketing-factory.de/

Geschaeftsfuehrer:    Peter Faisst   |   Katja Faisst
Karoline Steinfatt   |   Christoph Allefeld   |   Markus M. Kimmel