[TYPO3-commerce] RFC: #7862: bug: Class constructor of tx_commerce_attribute_value causes PHP Warning

[Ingo Schmitt]

Hi Sascha,

if the constructor is not needed, no warnings should be given. Thus I assume, the constructor is needed. 

Please do not remove Methods, instead please add a @deprecated to the documentation.

So -1 from me.

ingo

> This is an SVN patch request.
> 
> Type: Bug
> 
> Bugtracker references:
> http://forge.typo3.org/issues/show/7862
> 
> Branches:
> trunk
> 
> Problem:
> The Constructor in the class.tx_commerce_attribute_value class causes a php warning because of missing arguments. It expects the attribute value uid as first parameter but the TYPO3 api call "makeInstance" does not give any parameter to a new class.
> 
> Solution:
> Remove the constructor because we don't need it.
> 
> Notes:
> I think we can remove the Constructor because everything is dome by "makeInstance" and the "init" function of the class. The constructor also only calls the init function of the class.
> 
> 
> Regards
> Sascha Egerer
> <7862.patch>_______________________________________________
> TYPO3-team-commerce mailing list
> TYPO3-team-commerce at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-commerce


Mit freundlichen Gruessen
Ingo Schmitt

-- 
Marketing Factory Consulting GmbH  *   mailto:is at marketing-factory.de
Stephanienstrasse 36               *          Tel.: +49 211-361176-63
D-40211 Duesseldorf, Germany       *          Fax:  +49 211-361176-99
Amtsgericht Duesseldorf HRB 53971  * http://www.marketing-factory.de/

Geschaeftsfuehrer:    Peter Faisst   |   Katja Faisst
Karoline Steinfatt   |   Christoph Allefeld   |   Markus M. Kimmel