[TYPO3-commerce] FYI96: #6662: Related product without valid article causes PHP error

[Morten Olesen]

+1 (read)

Ingo Schmitt wrote:
> +1 by reading!
> 
>> Am 03.03.10 17:07, schrieb Ingo Schmitt:
>>> Hi Sascha,
>>>
>>> by reeding you patch is fine. By CGL you have to check the whitespeces.
>>> After changing them +1
>>>
>>> ingo
>>>> Am 02.03.10 18:56, schrieb Sascha Egerer:
>>>>> Hi,
>>>>>
>>>>> this is a SVN patch request.
>>>>>
>>>>> Type: Bugfix
>>>>>
>>>>> Branches: trunk, 0.11
>>>>>
>>>>> Forge reference: http://forge.typo3.org/issues/show/6662
>>>>>
>>>>> Problem:
>>>>>
>>>>> A product with a related product which has no active article end in an
>>>>> PHP error
>>>>> PHP Fatal error: Call to a member function returnAssocArray() on a
>>>>> non-object in
>>>>> XXX/typo3conf/ext/commerce/lib/class.tx_commerce_pibase.php on line 
>>>>> 634
>>>>>
>>>>> Solution:
>>>>>
>>>>> Products without articles should not be returned by the
>>>>> tx_commerce_product->getRelatedProducts function.
>>>>>
>>>>
>>>> Forgot to load the articles first. So the function
>>>> "getNumberOfArticles" always returs 0. But i think the function
>>>> "getNumberOfArticles" should load the Articles if they are not already
>>>> loaded.
>>>> What do you think?
>>>>
>>>> New patch attached.
>>>>
>>>
>>>
>>>
>>> Mit freundlichen Gruessen
>>
>> Hi Ingo,
>>
>> new patch attached. I think CGL is now correct, isn't it?
>>
>> Greets
>> Sascha
>>
> 
> 
> 
> Mit freundlichen Gruessen