[TYPO3-commerce] RFC: #7862: bug: Class constructor of tx_commerce_attribute_value causes PHP Warning

Sascha Egerer seg at softvision.de
Tue Jul 27 16:51:21 CEST 2010


Hi!
> 7862_v2.patch works for me, but I think we should use a strict check here.
> Please see the attached patch which applies to the new (reformatted)
> file. I also added a comment and fixed the if-row to be CGL compatible.

Yes looks good.

> OT:
> By the way, the first line of the phpdoc-comment in your patch looks a
> bit strange:
> <space><space><tab>/**
>
> That looks as if you are using the mc-editor. If so please disable the
> option "Fake half tabs" or "Halbe Tabs vortäuschen" which causes this
> misbehavior.
> See also: http://www.midnight-commander.org/ticket/2130

I use Zend Studio (Eclipse)... Looks like I've just added one tab to the 
two spaces wich have been already there...

So +1 for this by me ;-)

Regards

Sascha Egerer


More information about the TYPO3-team-commerce mailing list