[TYPO3-commerce] FYI 24: PHP warning due to wrong parameter count

[Ingo Schmitt]

-1

since TYPO3 always calls t3lib_div::makeInstance('tx_commerce_attribute_value') and afterwards calls init. Your solution won't be the TYPO3 way.

ingo

> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references: http://forge.typo3.org/issues/show/9042
> 
> Branches: trunk
> 
> Problem:
> tx_commerce_attribute_value constructor requires one to two parameters. Instead of passing them to the constructor, tx_commerce_attribute::get_all_values calls the constructor without parameters and then calls init() manually.
> 
> Reproduction:
> Insert pi1 into a page, create some articles with attributes, enable admin panel, look for the above error message.
> 
> Additional information:
> Core: Error handler (FE): PHP Warning: Missing argument 1 for tx_commerce_attribute_value::tx_commerce_attribute_value(), called in /var/www/trunk.localhost/TYPO3v4_trunk/t3lib/class.t3lib_div.php on line 5210 and defined in /var/www/trunk.localhost/htdocs/typo3conf/ext/commerce/lib/class.tx_commerce_attribute_value.php line 81
> 
> Solution:
> Replace the empty array with an empty string.
> 
> I will commit this one in 24 hours if noone complains.
> 
> Cheers, Michael
> <9042_v1.diff>_______________________________________________
> TYPO3-team-commerce mailing list
> TYPO3-team-commerce at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-commerce


Mit freundlichen Gruessen
Ingo Schmitt

-- 
Marketing Factory Consulting GmbH  *   mailto:is at marketing-factory.de
Stephanienstrasse 36               *          Tel.: +49 211-361176-63
D-40211 Duesseldorf, Germany       *          Fax:  +49 211-361176-99
Amtsgericht Duesseldorf HRB 53971  * http://www.marketing-factory.de/

Geschaeftsfuehrer:    Peter Faisst   |   Katja Faisst
Karoline Steinfatt   |   Christoph Allefeld   |   Markus M. Kimmel