[TYPO3-commerce] FYI96 - Speedimprovement add_fields

[Ingo Schmitt]

Hi all,

thanks for you comments. Committed to trunk.

Regards

ingo
> I think it's not so easy to check this during the configuration because 
> the function is called anywhere in a hook and can give any parameter as 
> string.
> 
> Attached a new patch.
> 
> Am 27.08.10 08:49, schrieb Morten Olesen:
>> +1 by reading
>>
>> On a seperate note I disagree with the @todo - making sure the fields
>> are available is a configuration time problem not a run time problem -
>> making the check at run time adds unneeded overhead, if the field was
>> missing that would've been discovered during configuration anyway.
>>
>>
>> /Morten Olesen
>>
>> On 2010-08-26 18:56, Ingo Schmitt wrote:
>>> Hi Sascha,
>>>
>>> yes, would be fine with me. Add typecasts?
>>>
>>> ingo
>>>
>>>> Yes sure that's true.
>>>> But we can change it a little bit ;-) See attached patch.
>>>>
>>>> What about this? Just an idea... But i think we should keep "model"
>>>> modifications as central as possible.
>>>>
>>>> sascha
>>>>
>>>> Am 26.08.10 17:44, schrieb Ingo Schmitt:
>>>>> Hi,
>>>>>
>>>>> I don't think it's cleaner to have a method with different
>>>>> variable-types as parameters acting different. Having this type of
>>>>> typejuggeling leads to errors, e.g. in your code you
>>>>> may lead to an error, if an object is passed as variable.
>>>>>
>>>>> ingo
>>>>>> I think it's cleaner to do the "add field" logic at a central
>>>>>> place, isn't it?
>>>>>>
>>>>>> Sascha Egerer
>>>>>>
>>>>>> Am 26.08.10 17:14, schrieb Benny Schimmer:
>>>>>>> +1 by reading
>>>>>>>
>>>>>>> Am 26.08.2010 16:54, schrieb Ingo Schmitt:
>>>>>>>> This is an SVN patch request.
>>>>>>>>
>>>>>>>> Type: Speed IMprovements
>>>>>>>>
>>>>>>>> Bugtracker references:
>>>>>>>> http://forge.typo3.org/issues/9471
>>>>>>>>
>>>>>>>> Branches:
>>>>>>>> trunk
>>>>>>>>
>>>>>>>> Description:
>>>>>>>> Use array merge instead of walking through the array and calling
>>>>>>>> add_field.
>>>>>>>>
>>>>>>>>
>>>>>>>> Mit freundlichen Gruessen
>>>>>>>
>>>>>>
>>>>>> <patch-9471_v2.txt>_______________________________________________
>>>>>> TYPO3-team-commerce mailing list
>>>>>> TYPO3-team-commerce at lists.typo3.org
>>>>>> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-commerce
>>>>>
>>>>>
>>>>> Mit freundlichen Gruessen
>>>>> Ingo Schmitt
>>>>>
>>>>
>>>> <patch-9471_v2.txt>_______________________________________________
>>>> TYPO3-team-commerce mailing list
>>>> TYPO3-team-commerce at lists.typo3.org
>>>> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-commerce
>>>
>>>
>>> Mit freundlichen Gruessen
>>> Ingo Schmitt
>>>
>>
> 



Mit freundlichen Gruessen
-- 
Ingo Schmitt                        mailto:is at marketing-factory.de
Marketing Factory Consulting GmbH   http://typo3.marketing-factory.de/
Content Management mit Typo3: Beratung - Schulung - Realisierung