[TYPO3-bugs] Please review issue 0004351

[Dmitry Dulepov]

Hi!

Oliver Klee wrote:
> Concerning files, a *missing* LF at the end creates a warning "no
> newline at end of file" in CVS (I'm not sure about SVN, though).

We did not have any problems in typo3 core with files that do not have LF in the last line. Works fine with both cvs and svn.

> 1. Do we have agreement (or at least no objections) that *for*files* a
> LF at the end is A Good Thing (TM)?

Neutral.

> 2. Should the adding of the final LF happen in
> t3lib_div::xml2array() or in the ll_xml extension?

Neutral.

> 3. Is anyone's itch big enough to write a patch to
> t3lib_div::xml2array() that allows skipping all unnecessary whitespace
> (which should be off by default as not to break old ll_xml versions)?

http://bugs.typo3.org/view.php?id=4358

-- 
Dmitry Dulepov

Web: http://typo3bloke.net/
Skype: callto:liels_bugs

"It is our choices, that show what we truly are,
far more than our abilities." (A.P.W.B.D.)