[TYPO3-bugs] Please review issue 0004351

[Martin Kutschker]

Dmitry Dulepov schrieb:
> Hi!
> 
> Oliver Klee wrote:
> 
>> the XML created by t3lib_div::array2xml() is missing a LF after the
>> final closing tag. I've attached a patch against TYPO3 4.0.2.
>>
>> http://bugs.typo3.org/view.php?id=4351
> 
> 
> By the way, you say there: "It is good style that every text file should 
> have a LF as the last char". Some time ago LFs were removed from typo3 
> source files because they caused PHP warning when gzip was enabled 
> ("output already started..."). So it is not *always* a good style.
> 
> As to XML: I do see it as a good thing because it adds extra useless 
> byte to each database field where xml is used. I would be happy if we 
> actually could get rid of all space characters in flexform xml...

What is good now, an extra LF or no? I am against any extra LF around 
(before and after) the outermost XML element or the PHP processing instruction.

Masi