[TYPO3-v4] New slider wizard embarrassment
Andreas Wolf
typo3ml at andreaswolf.info
Thu Nov 10 16:33:53 CET 2011
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
Am 10.11.2011 16:02, schrieb François Suter:
> From the code (lines 51-52) it appears possible to define a minimum
> and a maximum for the slider, which makes sense of course. However
> it relies on TCA field properties "min" and "max" for this, which
> is the real issue:
>
> 1) "min" does not exist (this is easy, we could just document it)
> 2) "max" exists (for input-type fields) but is used for the
> "maxlength" attribute and not for the maximum value. We have the
> "range" property for this instead.
>
> I am quite surprised that this actually got through the review
> process.
oh. Yeah. Hrm. I merged that. However this slipped through, that's not
good... Especially as I should have known about this from my TCEforms
knowledge...
> The situation must be corrected and I propose the following:
>
> - the slider wizard can be used for input-type and select-type
> fields. - for select-type fields, it's not an issue, because it
> doesn't need a min, nor a max. It just "slides" through the items
> array - for input-type fields, it *must* use the range property,
> because "max" serves another purpose.
I also think that this should be corrected the way you proposed - a
breaking change here should be no problem, as this feature is still
not really used anywhere.
Cheers
Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEAREIAAYFAk677uEACgkQHWtXp155bP8GpgCfTseKB2A2BexdSZS0VdFxeDMr
KmMAn3QO6aLdMUJw4pnMnEBXrXCdmOSr
=8YNM
-----END PGP SIGNATURE-----
More information about the TYPO3-project-v4
mailing list