[TYPO3-v4] Patch-for-a-patch, nitpicking and negative votes

[Steffen Kamper]

Hi,

Am 27.03.2011 18:26, schrieb Philipp Gampe:
> Hi Jigal,
>
> Jigal van Hemert wrote:
>
>> If the modification is a no-brainer (e.g. typo, CGL stuff like
>> abbreviations in names of new variables) there shouldn't be new voting
>> on the new patch set IMO. Core devs may commit (no, that's for a local
>> repository) ehm.. push (no, that's to Gerrit), ehm... well "submit
>> patches to the central repository" if they are no-brainers.
>>
>> If a core dev verified the patch and agrees with it, but sees some
>> no-brainer modifications (s)he should IMO make the changes and "submit"
>> it to the central repository directly.
>>
>> This is what we always did with replies like:
>> "Attached v4 with some CGL changes (whitespace and $shinyNewVariable
>> instead of $new_var). Committed to trunk in rev xxxx after my +1 by
>> reading and testing."
>>
>> What do you think?
>
> Sounds ok to me.
>
> That would mean, vote -1 only if something breaks (verified) or solution is
> the wrong approch (review).
>

corrct, -1 vote needs a good reason and a comment why it was given. 
Noone should vote -1 because of a inline comment need to be adjusted or 
a missing space or because he's in bad mood etc. Just comment that 
inline and make it independent from vote.

vg Steffen