[TYPO3-v4] Patch-for-a-patch, nitpicking and negative votes

[Jigal van Hemert]

Hi,

On 27-3-2011 11:38, François Suter wrote:
> That may also be a question of educating users. I have also made remarks
> about variable names and such in patches, but I don't give a -1 for
> that, because I expect whoever will commit to correct that. So it may
> just be a question of telling people "don't -1 just for spelling
> mistakes". Of course, committers must then be careful after that and
> consider all the requested clean ups.

The patch-for-a-patch "rule" was that the reviewer made those changes 
and included a new patch, right?

Of course, if you are the 'committer' ('commit' is now to local Git 
repository, so we have to find a new name for this I guess?) you can do 
this directly and review+submit these clean ups.

What do you think?

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert.