[TYPO3-v4] Patch-for-a-patch, nitpicking and negative votes

[Jigal van Hemert]

Hi,

On 27-3-2011 15:27, Philipp Gampe wrote:
> Jigal van Hemert wrote:
>> With reviewing code in Gerrit I see a tendency to just throw -1 votes if
>> there are tiny "problems" in the change. E.g. a comment which is
>> slightly wrong, bugtracker number misspelled, variable name not clear,
>
> Doesn't Gerrit clear those votes after pushing a new patch set?
> Then this would be ok for me, because you should vote again on the clean
> patch.

If the modification is a no-brainer (e.g. typo, CGL stuff like 
abbreviations in names of new variables) there shouldn't be new voting 
on the new patch set IMO. Core devs may commit (no, that's for a local 
repository) ehm.. push (no, that's to Gerrit), ehm... well "submit 
patches to the central repository" if they are no-brainers.

If a core dev verified the patch and agrees with it, but sees some 
no-brainer modifications (s)he should IMO make the changes and "submit" 
it to the central repository directly.

This is what we always did with replies like:
"Attached v4 with some CGL changes (whitespace and $shinyNewVariable 
instead of $new_var). Committed to trunk in rev xxxx after my +1 by 
reading and testing."

What do you think?

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert.