[TYPO3-doc] Restoring the official manual example
François Suter
fsu-lists at cobweb.ch
Wed Aug 1 18:35:52 CEST 2012
Hi Martin,
> It turns out that we can't use the replacement technique for figures.
> Docutils defines the replacement directive:
I see.
> They should therefor go directly into the text. And
> the caption and description belong to the text to make the ReST source
> complete und understandable.
Yes, it makes sense and is fine this way. Thanks for digging.
> I did that change in Patchset #6. At least I wanted it to become #6.
> What I got instead was this:
> http://review.typo3.org/13415
>
> Hhm, what did I do wrong? It's the first time I just tried the -m
> "Change-Id: ..." on the commandline, that's probably the error. I
> should have use the exect existing commit message!?
Indeed you created a new review:
https://review.typo3.org/#/c/13415/
You should have done a "git commit -a --amend". This adds your changes
to the current change and lets you edit the commit message (which you
generally want to leave as is). Then since the ChangeId is the same,
when you push again, it becomes a new patchset in the existing submission.
I'll try to see if I can bring you patchset "back home".
Cheers
--
Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch
More information about the TYPO3-project-documentation
mailing list