[TYPO3-performance] TS-Rendering - IMG_RESOURCE - 622 ms - Solution

[JoH asenau]

>> The question is: are we really shure that this works as reliable as
>> with
>> hashing the complete file?

Well - this is a very good question since currently we got the following
scenario:

md5_file is used by getCachedImageDimensions() only.
This again get s called by getImageDimensions() only.

There are 29 matches for "->getImageDimensions" all over current trunk:

TS_images_db (t3lib parsehtml proc)
used by RTE_transform only

maskImageOntoImage (t3lib stdgraphic)
GIFBUILDER only

imageMagickConvert (t3lib stdgraphic)
this one gives 16 matches (install tool) another 15 all over current trunk

IMGTEXT (tslib_content)
CSS styled content only

imageLinkWrap (tslib_content)
3 matches in CSS styled content and rtehtmlarea as well

getImgResource (tslib content)
21 matches GIFBUILDER, menus, pagegen and fluid

render_textpic (CSS styled content)
checkTheImageProcessing (install tool)
imageInsert (rtehtmlarea - dam browse media)
fileList (browse links)
renderFileInfo (show item)

Overall we got at least 75 output related places, where md5_file is
currently used.
So I don't think we can say for sure, that the new way definitely will be a
performance increase, just by comparing the functions directly.
Each time the new check decides "false", while the old check would have
decided "true", we will create a new file.
This might result in a performance loss if the number of returned "false"
will increase compared to the old check, which would eat up the boost we
might get due to faster response times of the check.

So without thorough testing I wouldn't want to make a decision here.

Just my 75 cents

Joey

-- 
Wenn man keine Ahnung hat: Einfach mal Fresse halten!
(If you have no clues: simply shut your gob sometimes!)
Dieter Nuhr, German comedian
Xing: http://contact.cybercraft.de
Twitter: http://twitter.com/bunnyfield
TYPO3 cookbook (2nd edition): http://www.typo3experts.com
TYPO3 workshops: http://workshops.eqony.com