[TYPO3-dev] check SID constant - install tool

[Tomas Norre Mikkelsen]

Hi,

I have some question regarding the check for sessions made in the 
typo3/sysext/install/mod/class.tx_install_session.php (line 129)

"} else if (defined('SID') {"

The line checks if the SID constant is defined, but not if its defined 
as an empty value. The problem is for me, when trying to use the 
install-tool i got following message.

==
Install Tool error
Error: Session already started by session_start().
Make sure no installed extension is starting a session in its 
ext_localconf.php or ext_tables.php.
==

But none of my extensions installed contains session_start() niegther in 
ext_localconf.php or ext_tables.php, or in the extensions in generel.

My questions are:

1) Why check for defined, but not if empty?

2) Should there be a patch/bug report? A quick solution that works for 
me is to edit the line to following:

" } else if (defined('SID') && strlen(SID) >= 0) {"

I'm quite sure its not the prettiest way to fix this, but it works, and 
i'm quite confused right now.

3) Is it me that have miss the overview of how this is surposed to work?

Any hints, suggestion etc are very welcome. I'm quite confused on this 
topic.

-- 
Venlig Hilsen / Best Regards
Tomas Norre Mikkelsen
Tomasnorre at gmail.com

Follow me at twitter
Twitter.com/tomasnorre