[TYPO3-dev] SVN pre-commit hooks to avoid commiting php files with syntax errors

[Bastian Waidelich]

Fabrizio Branca wrote:

Hi,

> today I played around with subversion's pre-commit hook.

After thinking about it again, I doubt that it makes sense to activate a 
pre-commit hook unless it can be configured/disabled..

A PHP syntax check is nice, but It (hopefully) only happens once in a 
blue moon, that someone commits code with syntax errors (and this would 
most probably be noticed very soon anyways).

In short, I don't think it's worth it to slow down commits (and forge in 
general!) for that.

Automatic CGL checks and testruns are great features, but definitely not 
for pre-commit hooks - Imagine you'd had to wait for all unit tests to 
be run at each commit. We should rather think about a CI solution in the 
long run.

What _could_ be useful for the v4 core IMO, is a pre-commit hook that 
checks the commit message (and maybe, whether the changelog-file has 
been updated).

All the best
Bastian