[TYPO3-dev] SVN pre-commit hooks to avoid commiting php files with syntax errors

[Fabrizio Branca]

Hi,

I really like the idea of having a Code Sniffer (btw, do Code Sniffs 
already exists for the TYPO3 CGL?) in place to check for violations to 
the cgl. (Or even to force some other rules like "no method should be 
longer than 30 loc"...). But this should not be done in a pre-commit 
hook. This is a typical task for a ci server performed after commits (or 
in other intervals).

IMHO pre-commit hooks should only prevent commiting on obviuous hooks.

Btw: Pre-commit hooks do not necessarily need to prohibit the commit. We 
could simply send out an email to a configured mail adress to inform 
about syntax checks or violations to the cgl and let the code be 
committed anyways!

Bye,

Fabrizio