[TYPO3-dev] Re: [TYPO3-core] RFC: #11249: Clean up: Deprecation clean-up in tslib_content::getData()

[Steffen Müller]

Hi.

#10357 introduced TS getText GP and set GPvar to deprecated.
#11249 fixes an issues which was introduced with that patch.

Now there seems to be a dissent about deprecation in TypoScript. Dmitry
suggests to keep TS stable and leave GPvar as is.

What do you think?

Revert the deprecated-part in #10357 or leave it and commit #11249?

On 05.06.2009 09:19 Dmitry Dulepov wrote:
> Francois Suter wrote:
>> 1) usage of "gpvar" is deprecated, but the deprecation log message
>> appears also when using "gp"
> 
> ...
> 
>> Solution:
>> 1) Add test to log message only when "gpvar" is used
> 
> I afraid this ia programmer's approach :( If you look into TSRef, you will see that gpvar returns a value from _POST or _GET. So from TS writer's view it is a fully legal functionality and if it suddenly starts giving warnings, it only means one thing: someone broke this functionality. So I am -1 to this change.
> 
> There is a more user friendly way. If we think about customer satisfaction, we can silently change "gpvar" to use t3lib_div::_GP() instead. There will be no need for a new "gp" at all. "gpvar" does have to correspond to t3lib_div::GPvar. Keep TS stable and change the underlying implementation to use better functions. Save people from unnecessary troubles. 
> 



-- 
cheers,
Steffen

TYPO3 Blog: http://www.t3node.com/