[Typo3-dev] New cron_cssstyledimgtext released

[Ernesto Baschny [cron IT]]

Hi Martin,

Martin Ficzel schrieb am 12.10.2005 18:57:

> i found a little issue with this extension
> 
> class.tx_croncssstyledimgtext_pi1.php::line359ff
> 
>> // calculating the tableWidth:
>> // TableWidth problems: It creates problems if the pictures are NOT as
>> wide as the tableWidth.
>> $tableWidth = max($imageRowsFinalWidths)+ $colspacing*($colCount) +
>> $colCount*$border*($borderSpace+$borderThickness)*2;
> 
> i think the colspacing is calculated wrong  i would suggest to change
> from  "$colspacing*($colCount)" to "$colspacing*($colCount-1)"

That's currently correct, because "colspacing" is used not only as the
space in between images, but also the space that separates the
image-block from the surrounding text. But I agree, something is not
very good here (e.g. if there is no surrounding text). I should honor
the textMargin setting. I'll take a closer look as soon as I have some time!

> another problem i had was the typoscript setup for tt_content.textpic
> and tt_content.image.
> 
> in ext:css_styled_content the tt_content.textpic is a reference to
> tt_content.textpic with the textfiled added. so changes to
> tt_content.image will affect also the tt_content.textpic object. i think
> the extension default typoscript should behave the same way. until now
> it is not a reference but a copy wich makes it necessary to create many
> settings twice.

True and I +1 that. I've added this change to my development version. As
soon as I have more to offer, I'll release a new version, and this
change will be included.

Thanks for your help, Martin!

Cheers,
Ernesto