[Typo3-dev] typolink.addQueryString is broken

[Martin Kutschker]

Hi!

typolink.addQueryString is suposed to add the QUERY_STRING to the URL 
parameters. This doesn't work:

1.) QUERY_STRING does not contain an initial &

This breaks all additional parameters because they are required to start 
with an &.

quote from tslib_content:

addQueryParams = $conf['addQueryString'] ? 
t3lib_div::getIndpEnv('QUERY_STRING') : '';
[...]
if (substr($addQueryParams,0,1)!='&') {
   $addQueryParams = '';
}

So typolink.addQueryString = 1 disables even typolink.additionalParams

2.) even if QUERY_STRING would contain a & id would be repeated

A possible simple fix for 1.) would be

addQueryParams = $conf['addQueryString'] ? 
'&'.t3lib_div::getIndpEnv('QUERY_STRING') : '';

(missing check for empty QUERY_STRING!)

But still this leaves a problem of a double id=nn within the new URL.

Questions:

How is this feature supposed to work? Under what circumstances has this 
ever been used?

Masi