[Typo3-dev] Colorpicker?

[Ingmar Schlecht]

Martin T. Kutschker schrieb:
> You mean you have contributed great code, only to see some (in your 
> opinion) inferior implementatoin in place?

Yes, that's what he means.

I got his colorpicker code as well, the idea was quite nice: Using a 
custom image as the color palette and making this image a server side 
imagemap. The PHP code then checked which color ther was on the pixel 
the user clicked.
Unfortunately I didn't find the time to properly review it.

However, I'm also quite suprised too to see the new colorpicker in 3.7...

I was just looking at the web CVS diff:
http://cvs.sourceforge.net/viewcvs.py/typo3/TYPO3core/typo3/wizard_colorpicker.php?r1=1.7&r2=1.8

The new code contains:

  * @author      Mathias Schreiber <schreiber at wmdb.de>
  * @author      Peter Kühn <peter at kuehn.com>
  * @author      Kasper Skaarhoj <typo3 at typo3.com>

That means Kasper did in fact use Mathias' code, but he probably changed 
it to how he thought was better. He should've asked you, I think.
However, I would be glad if you could sort this out off-list, Kasper 
currently doesn't read the dev list anyway.

cheers,
Ingmar