[Typo3-dev] 3.6.0RC1: t3lib_div::upload_copy_move()

[Markus Wagner]

Hi!

Just a quick note - don't know if it's something new for you:

There's a problem in the method t3lib_div::upload_copy_move(). 
It looks like this in my sources (comments are removed):

function upload_copy_move($source,$destination) {
        if (is_uploaded_file($source))  {
                return move_uploaded_file($source, $destination);
        } else @copy($source,$destination);
        
        if (@is_file($destination) && TYPO3_OS!='WIN')  { @chmod [...] }

        return false;
}

The early "return" will prevent chmod'ing of an successfully uploaded 
file. 

BTW: I just found the options "fileCreateMask" and "folderCreateMask"
and they made my day. No core hacking is now needed for using ACLs in 
the filesystem layer. Thank you for that small but so effective change!

Markus

-- 
"We can debug relationships, but it's always good policy 
to consider the people themselves to be features. People 
get annoyed when you try to debug them." (Larry Wall)