[Neos] RFC: Get rid of "lastVisitedUri"

Bastian Waidelich bastian at typo3.org
Mon Nov 25 14:25:20 CET 2013


Aske Ertmann wrote:

Hi Aske,


> The performanceshould be negligible [...]

I did some rough benchmarks and the performance hit seems to be very 
minor indeed.
It seems this boils down to balancing the advantage of editors to be 
redirected to the last visited page and a (very small) performance hit 
on every request in live workspace.

I can't judge whether this very drawback is negligible or not, but I 
agree to the measures (putting it in an external file...).


But we should really avoid creating or even storing URLs on the client 
side. In this case we "reconstruct" the URL to redirect by hard-coding
"@<workspace>.html" to the lastVisitedUri that was stored in the session.

This breaks support for installations without RewriteEngine support. It 
also breaks custom routes and it leads to a 404 if the page has been 
moved in the meantime.

I'd suggest to store the identifier of the current document node instead 
and redirect to that upon login (if it is accessible).
Also I don't see a reason why we need to store it in a session at all. 
We should instead add a hidden field to the logout form with the 
identifier of the last edited document node.


> Being able to add /neos is then something that the editor has to remember and do
> which I think most will forget however this is happens automatically

I'm not sure whether I got this one right.

-- 
Bastian Waidelich


More information about the Neos mailing list