[Neos] Styles folder

Rens Admiraal rens.admiraal at typo3.org
Tue May 21 15:36:34 CEST 2013


K, good points... My vote would then be to stick to the docs and do a +1 
to Styles and a +1 to Scripts.


Greetz,
Rens

Op 5/21/13 15:15 , Aske Ertmann schreef:
> Don't remember being involved with that one before the CPH sprint, but since the discussion and documentation change was done afterwards I guess that's the decision. Also a good handful of people participated, but I must admit I missed this one as well since it went on in the Flow General discussion.
>
> I'd suggest we keep to "Styles" since it covers SCSS, SASS, LESS and CSS (even compass config). Then we also follow the guidelines.
>
> I would advice against copying other frameworks since most of them have inconsistencies and don't use camel case but lowercase file extensions for folder names and sometimes things like "lib" and "docs". I would strongly try to avoid this since we've already come a long way using camel case IMO in Flow and should stick to that.
>
> Regarding the "Scripts", I don't mind if it either "Scripts" or "JavaScript". I would say if you have more than one kind of scripts (in Private/Public) you should be more specific, but we don't have that for Neos currently. Using "Scripts" would be consistent with the guidelines, however it could become an issue later on.
>
> Two questions:
> 1) +1/-1 for sticking with "Styles"?
> 2) +1 for "Scripts" or "JavaScript"?
>
> On 21/05/2013, at 14.51, Rens Admiraal wrote:
>
>> Actually I think we all lurk too much amnesia spray tbh ;) It seems like the discussion Bastian linked is from end of last year, while I remember a forge issue which was assigned to Markus from before Kopenhagen which stated the StyleSheet convention :-) But hey, you're not gonna find that one in our cool search function of the issuetracker ;-)
>>
>> But ok, being here right now we should indeed decide what to go for. Are we heading for Styles and Scripts, or are we starting to not reinvent this wheel ourselves and follow some 'public like standard' like HTML5 boilerplate, or maybe look at what other frameworks use?
>>
>> I completely didn't notice the 2nd discussion end of last year btw :(
>> But most important: let's settle this for once and for all ;)
>>
>> Greetz,
>> Rens
>>
>>
>>
>>
>>
>> Op 5/21/13 13:12 , Aske Ertmann schreef:
>>> Ah so it was actually me who didn't use too much amnesia spray, good to know. Thanks for pointing in the right direction Bastian.
>>>
>>> According to http://docs.typo3.org/flow/TYPO3FlowDocumentation/TheDefinitiveGuide/PartIII/PackageManagement.html#package-directory-layout
>>>
>>> It should be Styles and not StyleSheet/StyleSheets which is what I changed it to. We should consider renaming JavaScript to Scripts as well to keep consistent with our own documentation.
>>>
>>> Any suggestions on how to proceed?
>>>
>>> On 20/05/2013, at 23.49, Aske Ertmann wrote:
>>>
>>>> Hi
>>>>
>>>> I remembered on us settling for something and I thought it was "Styles", but I can't find it anywhere and AFAIK we didn't change it back then only discussed what how we should do it, so it could be consistent across packages. But maybe I just remembered wrong.
>>>>
>>>> After checking it seems that TYPO3.Setup follows the same naming. So I think you're right about that's what we decided back then. However we did change the file names anyway and for that reason custom PageHead will be broken anyway, and we shouldn't let this stop us naming it what we find best. Changing it now is a lot better than changing it later on and Neos shouldn't really be considered stable to begin with. Anyway the change was more about moving the SCSS files into Private and not about the actual folder name. Sorry for the confusion.
>>>>
>>>> Anyway could be good if we have any history about this because I can't seem to find anything about it and document it somewhere.
>>>>
>>>> I totally agree that we need to rework the PageHead to use TypoScript instead and that discussion is already planned for our next meeting.
>>>>
>>>> Aske
>>>>
>>>> On May 19, 2013, at 8:11 PM, Rens Admiraal <rens.admiraal at typo3.org> wrote:
>>>>
>>>>> Hey,
>>>>>
>>>>> I can only remember settling for StyleSheet ago after a long discussion long long long ago, and afaik we had some kind of agreement on name the folder to it's actual content like the language (JavaScript) or the type of resources. And I find 'styles' quite general in that regard... We also didn't vote for 'Scripts'.
>>>>>
>>>>> Personally I don't see a big + for Styles in regard to StyleSheet, and as such it would be smart to not break anything. Now the master could be kind a broken for people who use Neos already, although this is of course already true because of the javascript renaming.
>>>>>
>>>>> I don't wanna block stuff or something, but I would vote for reverting this change. Renaming the inner structure of the JavaScript folder is different then renaming folders in Public/ while we just decided somewhere last year to communicate some kind of guideline which could be used by everyone as sane folder names...
>>>>>
>>>>> Big +2 for working around our PageHead.html template, it would be really cool to have this javascript / stylesheet thing in TypoScript2
>>>>>
>>>>> Greetz,
>>>>> Rens
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Op 5/18/13 08:34 , Sebastian Kurfürst schreef:
>>>>>> Hey,
>>>>>>
>>>>>> Aske said they have discussed it somewhen and settled for Styles.
>>>>>>
>>>>>> +2 for renaming to a consistent naming; instead of overriding PageHead
>>>>>> we rather should make sure everything which needs to be adjusted there
>>>>>> can be done via TypoScript. Overriding PageHead.html completely should
>>>>>> only be a last-resort to be needed in almost no project.
>>>>>>
>>>>>> Greets, Sebastian
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Neos mailing list
>>>>> Neos at lists.typo3.org
>>>>> http://lists.typo3.org/cgi-bin/mailman/listinfo/neos
>>>>
>>>> _______________________________________________
>>>> Neos mailing list
>>>> Neos at lists.typo3.org
>>>> http://lists.typo3.org/cgi-bin/mailman/listinfo/neos
>>>
>>
>> _______________________________________________
>> Neos mailing list
>> Neos at lists.typo3.org
>> http://lists.typo3.org/cgi-bin/mailman/listinfo/neos
>



More information about the Neos mailing list