[Flow] TYPO3.TYPO3CR depends on TYPO3.Neos

[Søren Malling]

Hi Steffen,

Please comment inside the review so we can keep track of people comments
for the different patchsets :-)

Regarding contribution, have a look at this walkthrough

http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine

I will update the patches later today if you don't do it before me
(challenge?)  ;-)

Cheers

Søren


On Thu, Dec 19, 2013 at 10:00 PM, Steffen Wickham <steffen at gaming-inc.de>wrote:

> Hello Søren,
>
> thank you for your quick response! :)
> I found two issues in the patch set fot TYPO3CR.
>
> First of all the required method "getUnpublishedNodesCount()" defined in
> the PublishServiceInterface wasn't included in the PublishService. I
> took the snipped from the same Neos method you got the other stuff so
> maybe it has to be removed in neos as well.
> The second issue were missing references to the Workspace and
> NodeInterface Model within the interface definition so I'd added them
> myself.
>
> I'm sorry that I didn't upload the patches by myself to Gerrit but I'm
> not able to handle gerrit by my own :-(
> So please have a look at my diff to the patch set 2 from gerrit at
> https://gist.github.com/anonymous/8046156
>
> Cheers
> Steffen
>
>
>
> Am 19.12.2013 17:08, schrieb Søren Malling:
> > Thanks for bringing up again, I've been wanting to fix this for quiet
> some
> > time!
> >
> > Please test the following two patches (or at least the one for
> > TYPO3.TYPO3CR if you don't work with Neos)
> >
> > For TYPO3.TYPO3CR
> > https://review.typo3.org/#/c/26495/
> >
> > For TYPO3.Neos
> > https://review.typo3.org/#/c/26496/
> >
> > Find it here
> >
> > https://review.typo3.org/#/q/status:open+branch:master+topic:46464,n,z
> >
> > Cheers
> >
> > Søren
> >
> >
> >
> > On Thu, Dec 19, 2013 at 4:34 PM, Steffen Wickham <steffen at gaming-inc.de
> >wrote:
> >
> >> Hey guys,
> >>
> >> I'm trying to play around with TYPO3.TYPO3CR but got in trouble as there
> >> is a hard coded linkage to "TYPO3.Neos", which I won't install for this
> >> project.
> >>
> >> In \TYPO3\TYPO3CR\Domain\Model\Workspace there is an injection for the
> >> Neos "publishingService" (lines 68-72) which will be used in the method
> >> "publish()" (lines 130-142) only. I don't know if it is really necessary
> >> to put in this linkage but it will break dependecies as Neos is not a
> >> required package for composer.
> >>
> >> So I will suggest to review this code part.
> >>
> >> Have a nice day! :)
> >> Steffen
> >> _______________________________________________
> >> Flow mailing list
> >> Flow at lists.typo3.org
> >> http://lists.typo3.org/cgi-bin/mailman/listinfo/flow
> >>
> > _______________________________________________
> > Flow mailing list
> > Flow at lists.typo3.org
> > http://lists.typo3.org/cgi-bin/mailman/listinfo/flow
>
> _______________________________________________
> Flow mailing list
> Flow at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/flow
>