[FLOW3-general] Some simple improvement in code, what should I do with that

[Karsten Dambekalns]

Hi.

On 01.04.11 11:54, Marcus 'biesior' Biesioroff wrote:
> Just few things to know, according to this page :
> http://forge.typo3.org/projects/team-forge/wiki/Gerrit_and_Git_Quickstart
> I stack on: "Now, Git does the merge, and re-opens the editor to adjust
> the Commit Message..."
> 
> I've got a git message:
> 
> "Successfully rebased and updated
> refs/heads/feature-currencyViewHelper-changes."
> 
> and had no chance to adjust the commit message with required data (maybe
> because there was only one commit?) how to add the last comment? should
> I re-commit the change with proper description?

Yes, no need to do an interactive rebase unless you want to
combine/reorder/change *multiple* commits.

If you want to adjust the commit message of the last commit, just do
"git commit --amend".

> and last question: is it required to create issue on redmine to send
> review or it can be sent as 'standalone' review?

Depends on your judgement. If you think an issue would be good (like a
lot of people might look for a reported problem or it's a real bummer),
create one. If not, no problem.

Regards,
Karsten