[TYPO3-dam-devel] RFC #8395: dam_ttcontent: captionsplit does not work

[Bjoern Pedersen]

Am 09.12.2010 14:19, schrieb Lorenz Ulrich:
> Hi everyone :)!
> 
> This is an SVN patch request.
> 
> Type: bugfix
> 
> BT reference: http://bugs.typo3.org/view.php?id=8395
> 
> Problem:
> In the standard Typoscript config of dam_ttcontent there is no caption
> split if captions for images are taken from DAM metadata.
> 
> Solution:
> The configuration should respect the setting in the constants editor
> "Images, caption: If this is checked, then each image will get a caption
> from DAM meta data."
> 
> So the patch makes it work like this:
> If "styles.content.imgtext.captionEach = 1" (default behaviour),
> captions will be taken from DAM meta data, one line per image.
> If "styles.content.imgtext.captionEach = 0" (can be changed in the
> constants editor), captions will be taken from Caption field in the CE,
> one line per image.
> 
> At this occasion I removed
> br = 1
> fontTag = <p class="csc-caption">|
> This is neither necessary (you can add styles to the dd) nor standard
> CSC behaviour.
> 
> 
> Best regards,
> 
> 
> Lorenz

Looks mainly fine by reading. Maybe a bit better fallback handling for
the following scenario would be nice:

A mixed setup with both  captions in DAM and in the content element.

1) So, if the content element caption is empty, still fall back to the
DAM caption, even if captionEach is 0

2) if DAM caption is empty, fallback to the content caption with split
even if captionEach is set.

So a +0.5 from me.

Björn