[TYPO3-dam-devel] RFC #14724 Bug: Indexing: Only the last chosen option will be shown in step 4

[Ulrich Lorenz PHZ Luzern]

+1 by reading and testing.

Thanks!


Lorenz

> -----Ursprüngliche Nachricht-----
> Von: typo3-team-dam-bounces at lists.typo3.org [mailto:typo3-team-dam-
> bounces at lists.typo3.org] Im Auftrag von Andy Grunwald [wmdb]
> Gesendet: Dienstag, 15. Juni 2010 09:33
> An: typo3-team-dam at lists.typo3.org
> Betreff: [TYPO3-dam-devel] RFC #14724 Bug: Indexing: Only the last
> chosen option will be shown in step 4
> 
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=14724
> 
> Branches:
> Trunk, 1.1.5
> 
> Problem:
> In the indexer wizard, you can chose some options in step 2
> (subdirectories, reindexing, ...).
> If you chose some options, these options will be listed in step 4.
> But in the trunk version of DAM, there will be only the last chosen
> option listed many times.
> 
> If you chose 3 different options, for example, reindexing,
> subdirectories and upper case titles (dam_demo). In step 4 there are 3
> listet options: upper case titles, upper case titles, upper case
> titles.
> 
> The attached screenshot shows the problem and the attached patch solved
> it.
> 
> How to reproduce:
> - Chose "Media" -> "Indexing"
> - Chose one Folder
> - Go to "Step 2"
> - Chose more than one option (two, or three or more)
> - Go to "Step 4"
> - Below the buttons "Back / Start you will see two or three lines (how
> many options you have chosen?) of the LAST chosen option
> 
> Solution:
> In the method "initEnabledRules" of "lib/class.tx_dam_indexing.php",
> the
> indexing rules will be initialized. During this process, objects will
> be
> handles as references. This is not wrong, but the mistake is, that
> there
> will be created a second reference to a variable which will be
> overwritten by every loop of the for each statement.
> In case of the previous references, the last index rule overwrites ALL
> previous rules.
> Find and fix it ;)
> 
> Notes:
> Patch is similar to Bug #0012856: Stage two of indexing process lists
> Dry Run <http://bugs.typo3.org/view.php?id=12856>
> 
> Thanks to Peter Kühn for some explanations.
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-dam mailing list
> TYPO3-team-dam at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-dam