[TYPO3-dam-devel] RFC #14724 Bug: Indexing: Only the last chosen option will be shown in step 4

[Andy Grunwald [wmdb]]

This is an SVN patch request.

Type: Bugfix

Bugtracker references:
http://bugs.typo3.org/view.php?id=14724

Branches:
Trunk, 1.1.5

Problem:
In the indexer wizard, you can chose some options in step 2 
(subdirectories, reindexing, ...).
If you chose some options, these options will be listed in step 4.
But in the trunk version of DAM, there will be only the last chosen 
option listed many times.

If you chose 3 different options, for example, reindexing, 
subdirectories and upper case titles (dam_demo). In step 4 there are 3 
listet options: upper case titles, upper case titles, upper case titles.

The attached screenshot shows the problem and the attached patch solved it.

How to reproduce:
- Chose "Media" -> "Indexing"
- Chose one Folder
- Go to "Step 2"
- Chose more than one option (two, or three or more)
- Go to "Step 4"
- Below the buttons "Back / Start you will see two or three lines (how 
many options you have chosen?) of the LAST chosen option

Solution:
In the method "initEnabledRules" of "lib/class.tx_dam_indexing.php", the 
indexing rules will be initialized. During this process, objects will be 
handles as references. This is not wrong, but the mistake is, that there 
will be created a second reference to a variable which will be 
overwritten by every loop of the for each statement.
In case of the previous references, the last index rule overwrites ALL 
previous rules.
Find and fix it ;)

Notes:
Patch is similar to Bug #0012856: Stage two of indexing process lists 
Dry Run <http://bugs.typo3.org/view.php?id=12856>

Thanks to Peter Kühn for some explanations.