[TYPO3-dam-devel] RFC #11350: Not able to preview image(s) in workspace inserted to a Text w/Image content element.

[Michiel Roos [netcreators]]

Op 2/5/10 1:26 PM, Chris Müller schreef:
> +1 by reading and testing
> 
> Am 03.02.2010 10:03, schrieb Francois Suter:
>> REMINDER #1
>>
>> The patch is quite simple and solves an embarrassing problem.
>>
>> Cheers
>>
>>> Hi,
>>>
>>> This is a SVN patch request.
>>>
>>> Branches:
>>> Trunk and 1.1
>>>
>>> Reference:
>>> http://bugs.typo3.org/view.php?id=11350
>>>
>>> Problem:
>>> When using dam_ttcontent and previewing a changed Image or Text w/Image
>>> content element in a workspace, the preview shows the live version
>>> instead.
>>> This is due to class tx_dam_tsfe relying on
>>> t3lib_BEfunc::getWorkspaceVersionOfRecord() to get the workspace version
>>> of the current tt_content. This fails because this method checks if the
>>> sysext "version" is loaded, which is not the case in the FE (it has the
>>> new flag "doNotLoadInFE" set in TYPO3 4.3.x).
>>>
>>> Solution:
>>> Although the preview is started from the BE, it still happens in the FE
>>> and thus is is wrong IMO to use a method from class t3lib_BEfunc in such
>>> a case. The attached patch relies on
>>> t3lib_pageSelect::getWorkspaceVersionOfRecord() instead (accessed via
>>> $GLOBALS['TSFE']->sys_page). The check after this call must be changed
>>> too, because the return value can be more varied.
>>>
>>> Cheers
>>>
>>
>>
>>
> 
Comitted to 1.1 and trunk

-- 

Met vriendelijke groet / Warm regards,


Michiel Roos
TYPO3 Developer
Certified TYPO3 Integrator

t. 06 458 7 8 9 10
w. netcreators.com
_____________________________________________
Netcreators: Open Source, Open Minds, Open People
_____________________________________________

TYPO3 Developer gezocht, lees de vacature online:
http://www.netcreators.com/over-netcreators/vacatures/