[TYPO3-dam-devel] RFC: Bugfix: 10243, Media tag: ATagParams can't wrap dam fields
Michiel Roos [netcreators]
michiel at netcreators.com
Fri May 8 08:33:28 CEST 2009
Stanislas Rolland schreef:
> Olivier Schopfer a écrit :
>> So what?
>>
>> Just surprised to get no feedback...
>>
> I think you did not answer Michiel's question.
>
>>>
>>>
>>> Michiel Roos [netcreators] wrote:
>>>>
>>>> So why place the line where you placed it?
>>>>
>>>> And why not move it down to join:
>>>> $finalTagParts['url'] = $this->cObj->lastTypoLinkUrl;
>>>> $finalTagParts['targetParams'] = $target ? ' target="'.$target.'"' :
>>>> '';
>>>> $finalTagParts['TYPE'] = 'file';
>>>>
> +1 from reading, but attaching a new version of the patch that moves the
> statement further down where the other items of array $finalTagParts are
> assigned.
>
> Regards,
> Stanislas
>
+1
Please commit
--
Michiel Roos
TYPO3 Developer
06 458 7 8 9 10
________________________________________________________________________
Netcreators: Open Source, Open Minds, Open People
________________________________________________________________________
More information about the TYPO3-team-dam
mailing list