[TYPO3-dam-devel] RFC: Bugfix: 10243, Media tag: ATagParams can't wrap dam fields

[Olivier Schopfer]

Stanislas Rolland wrote:
> Olivier Schopfer a écrit :
>> So what?
>>
>> Just surprised to get no feedback...
>>
> I think you did not answer Michiel's question.
> 
>>>
>>>
>>> Michiel Roos [netcreators] wrote:
>>>>
>>>> So why place the line where you placed it?
>>>>
>>>> And why not move it down to join:
>>>> $finalTagParts['url'] = $this->cObj->lastTypoLinkUrl;
>>>> $finalTagParts['targetParams'] = $target ? ' target="'.$target.'"' : 
>>>> '';
>>>> $finalTagParts['TYPE'] = 'file';
>>>>
> +1 from reading, but attaching a new version of the patch that moves the 
> statement further down where the other items of array $finalTagParts are 
> assigned.
> 
> Regards,
> Stanislas
> 

Thanks Stanislas, no problem with that correction. I agree that it looks 
better this way.

And it works.

+1 by testing (to patch v2)

Olivier

To