[TYPO3-dam-devel] RFC: Bugfix: 10243, Media tag: ATagParams can't wrap dam fields

[Olivier Schopfer]

So what?

Just surprised to get no feedback...

Olivier

Olivier Schopfer wrote:
> Thanks for your feedback.
> 
> My point is that I want to use som dam fields in the A tag parameters.
> 
> I want this kind of typoscript to work:
> 
> plugin.tx_dam_tsfemediatag.tag.typolink.ATagParams.dataWrap = 
> onClick="javascript:pageTracker._trackPageview('{ field : 
> txdam_file_path }{ field : txdam_file_name }');"
> 
> This should generate something like:
> 
> onClick="javascript:pageTracker._trackPageview('fileadmin/documents/doc.pdf');" 
> 
> 
> It remains empty instead.
> 
> The following line:
> 
> $finalTagParts['aTagParams'] = $this->cObj->getATagParams($conf);
> 
> needs to be placed AFTER this one:
> 
> $this->addMetaToData ($meta);
> 
> so that $this->cObj->data is filled with the dam fields that are then 
> used by getATagParams($conf).
> 
> Hope this is clearer.
> 
> Olivier
> 
> 
> Michiel Roos [netcreators] wrote:
>> Olivier Schopfer schreef:
>>> This is a svn patch request.
>>>
>>> Type: bugfix
>>>
>>> Description:
>>> The computation of the ATagParams stdWrap takes place BEFORE the dam
>>> fields are available, maiking it impossible to use these fields. This
>>> patch moves the computation of ATagParams to the right place.
>>>
>>> Branches:
>>> 1.1.1
>>> Head
>>>
>>> Bugtracker reference: http://bugs.typo3.org/view.php?id=10243
>>>
>>> Kind regards,
>>>
>>> Olivier
>>>
>>
>> Hi,
>>
>> I don't understand:
>> $finalTagParts['aTagParams'] = $this->cObj->getATagParams($conf);
>>
>> Just uses $conf which is not touched in the function.
>>
>> So why place the line where you placed it?
>>
>> And why not move it down to join:
>> $finalTagParts['url'] = $this->cObj->lastTypoLinkUrl;
>> $finalTagParts['targetParams'] = $target ? ' target="'.$target.'"' : '';
>> $finalTagParts['TYPE'] = 'file';
>>
>> Kind regards,
>>
>>
>> Michiel Roos