[TYPO3-dam-devel] RFC #7342-2: dam_catedit doesn't work properly with 4.2-trunk (clickmenu javascript error), part 2

[Benjamin Mack]

Commited the attached patch to tx_dam_catedit/trunk.

Also updated the ext version to 1.1.0-dev

Hence: The new version from typo3xdev will work with 4.2 seamlessly.

Modified files:
===============
M      mod1/index.php
M      ext_tables.php
A      lib/class.tx_damcatedit_cm.php
D      lib/class.tx_damcatedit_div.php
D      lib/class.tx_damcatedit_clickmenu.php
M      ChangeLog
M      class.tx_dam_db_list2.php
D      mod_clickmenu
D      mod_clickmenu/moduleicon.gif
D      mod_clickmenu/locallang_mod.xml
D      mod_clickmenu/conf.php
D      mod_clickmenu/index.php
M      ext_emconf.php


David Steeb wrote:
> Hey boys,
> 
> this is a SVN patch request.
> 
> Type: cleanup / bugfix
> 
> Extension: DAM_catedit
> 
> Branches: trunk
> 
> Introduction:
> The extension dam_catedit does not work with 4.2. Why? Because when it 
> was created, the initial author copied the complete 
> typo3/alt_clickmenu.php to 
> dam_catedit/lib/class.tx_damcatedit_clickmenu.php
> well, this was like the alt_clickmenu.php from TYPO3 3.7 or 3.8 and the 
> clickmenu code developed further. The whole idea of the clickmenu is 
> that you can use the native typo3/alt_clickmenu.php and 
> template::wrapItemInClickMenu() and hook into the clickmenu rendering 
> process.
> 
> Apparantly a lot of other extensions (DAM itself, commerce and graytree 
> lib) have now the same problem because the API changed and copying files 
> from the core is just not the way to go.
> 
> Also the list-view of the dam_catedit-module was broken.
> 
> Solution:
> I stripped down the whole extension by removing unnecessary files, 
> because I used the native clickmenu api. Also I fixed the list view, 
> because the title-field of the category was fixed_lgd'd twice after 
> <span>-tags and title-attribute were added which led to invalid 
> HTML-code and messed up list-view.
> The attached patch fixes all of these issues and now the extension works 
> again. Please note that you also have to apply Benni's patch.
> 
> Greetings,
> 
> David
> 

-- 
greetings,
benni.
-SDG-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080530_clickmenu.patch
Type: text/x-diff
Size: 89950 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080530/46c0d10a/attachment-0001.patch