[TYPO3-dam-devel] RFC #7342-1: dam_catedit doesn't work properly with 4.2-trunk (clickmenu javascript error), part 1

[Benjamin Mack]

Hey boys,

this is a SVN patch request.

Type: cleanup / bugfix

Extension: DAM

Branches: DAM 1.1 (Trunk) only

Introduction:
The extension dam_catedit does not work with 4.2. Why? Because when it 
was created, the initial author copied the complete 
typo3/alt_clickmenu.php to damcatedit/lib/class.tx_damcatedit_clickmenu.php
well, this was like the alt_clickmenu.php from TYPO3 3.7 or 3.8 and the 
clickmenu code developed further. The whole idea of the clickmenu is 
that you can use the native typo3/alt_clickmenu.php and 
template::wrapItemInClickMenu() and hook into the clickmenu rendering 
process.

Apparantly a lot of other extensions (DAM itself, commerce and graytree 
lib) have now the same problem because the API changed and copying files 
from the core is just not the way to go.

Description:
OK. so now for the bug. There is a DAM code that hardcode checks if 
dam_catedit is installed and then does not take the native API code from 
typo3/template.php but the old code from dam_catedit. This has to go in DAM.

Solution / Notes:
This first patch only cleans up the DAM code from using the old 
dam_catedit wrap. But with this patch it is not possible yet to use 
dam_catedit again. It is basically just a start to clean up this mess 
and it is needed to our changes we did in dam_catedit. The second patch 
(coming in the next days, which applies to dam_catedit alone) will 
modify dam_catedit and make it work again.

-- 
greetings,
benni.
-SDG-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080517_tx_dam_cleanup_clickmenu.patch
Type: text/x-diff
Size: 1062 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080517/edb984be/attachment.patch