[TYPO3-dam-devel] RFC: Bugfix: 5527: Go to editing of DAM record from the content element (image)

[Michiel Roos]

Hi Peter. I cannot get dam to work applying your patch, with or  
without dam_ttcontent.


On May 9, 2008, at 4:58 PM, Peter Kuehn [wmdb] wrote:

> Hi benni!
>
> i found what happens when i uploaded my screenshot to mantis and
> compared to yours:
>
> my patch works *with* dam_ttcontent - yours dont.
> your patch works *without* tt_content - mine does not.
> check it out!
> :D:D:D:D:D
>
> so finally:
> +1 on BOTH!
>
> btw: i dont see any reason why someone would like to use dam without
> dam_ttcontent under normal conditions (content management). do you?
>
> cheers and happy hollidays
> pekue
>
> Peter Kühn schrieb:
>> This is a svn patch request.
>>
>> Type: bugfix
>>
>> Description:
>> Now it is not possible to go to editing of DAM record from the  
>> content
>> element (image, text with image), where this record is used.
>>
>> Steps to reproduce:
>> - create a content element of type "Image"
>> - add a DAM-record to the images field
>> - save the record without closing it
>> - if the form is back, click on image-icon top-left of the
>> thumbnailsection of the added image
>>
>> Expected behaviour:
>> like fx. in CType "Insert Records" a clickmenu should appear with an
>> edit, info and copy option for the referenced record.
>>
>> Observed behaviour:
>> the ajax request for the content of the clickmenu is sent in the
>> background, but alt_clickmenu.php returns a result without the  
>> expected
>> entries.
>>
>> The reason for this is, that t3lib_TCEforms::getClickMenu() renders a
>> get-parameter enDisItems with the value '+copy,info,edit,view'
>> (hardcoded on line 3304 in the current 4.1.5 and checked to *not*  
>> have
>> been changed in 4.2beta1a). The plus as the first char defines that  
>> only
>> the given keys may be returned.
>> As defined in dam/ext_tables.php on line 315 the key for fx. the  
>> action
>> to edit a dam-record is "tx_dam_action_editRec" instead of "edit"  
>> as in
>> TCEforms, the action is not returned.
>>
>> The provided solution may look a little brute, but I think it can be
>> done this way cause the reason for this missbehave (the
>> enDisItems=+copy,info,edit,view param in the request) is hardcoded in
>> TCEforms and therefore works like sort of a switch, indicating to
>> display a certain type of clickmenu that should not be overwritten by
>> dam-actions.
>>
>> please ack or comment.
>> grtz
>> pekue
>>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-dam mailing list
> TYPO3-team-dam at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam


Met vriendelijke groet,

Michiel Roos

Netcreators BV :: creation and innovation
www.netcreators.com

Interesse in werken bij Netcreators?
http://www.netcreators.com/bedrijf/vacatures/